Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ac8b50f5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "$MODEL_CHOICE" in | ||
| 1) MODEL="sonnet" ;; | ||
| 2) MODEL="opus" ;; | ||
| read -rp "Choose [1-3, s]: " PROVIDER_CHOICE |
There was a problem hiding this comment.
The new retry loop does not check whether read succeeded, so if stdin reaches EOF (for example in a non-interactive/heredoc run with missing answers, or after Ctrl-D), PROVIDER_CHOICE stays empty, matches the * branch, and while [ -z "$PROVIDER" ] repeats forever. This is a regression from the previous behavior, which exited on invalid provider input, and it can hang automated setup jobs until they are force-killed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is intended behavior, it loops until a valid selection is made, so as to not invalidate previous entries erroneously, this is not an automated but an interactive setup tool.
|
Oops this was v1, v2 incoming |
can i close this pr then? |
2 participants
Also fixed the setup so it doesn't bail out prematurely if you make a typo